Re: [PATCH RESEND v2 3/3] tests/qtest: add K230 UART test

WX Chen <[email protected]>
Newsgroups org.nongnu.qemu-riscv,org.nongnu.qemu-devel
Message-ID <[email protected]>
Hi Daniel,

Thanks for the review!


On 8/6/26 04:10, Daniel Henrique Barboza wrote:
>
> Any reason to use g_usleep() instead of qtest_clock_step()?  There are 
> a couple
> of g_usleep() uses in the code but you used lots of qtest_clock_step() 
> too.
>
> AFAIK g_usleep() is wall time and qtest_clock_step() is simulated 
> time, and
> I guess you should be using qtest_clock_step() for all the pollings 
> you're
> doing in this file.
>

You're right, there's no reason to mix them here. I'll fix this in v3.


Regards,

WX Chen
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.