Re: [PATCH v2 1/3] hw/misc/k230_iomux: add Kendryte K230 IOMUX model
Junze Cao <[email protected]>
| Newsgroups | org.nongnu.qemu-riscv,org.nongnu.qemu-devel |
|---|---|
| Message-ID | <178653253398.92831.18366427252686733896.b4-review@b4> |
On Tue, 14 Jul 2026 18:22:00 +0800, Kangjie Huang <[email protected]> wrote: > diff --git a/hw/misc/k230_iomux.c b/hw/misc/k230_iomux.c > new file mode 100644 > index 0000000000..cc40dc8ae4 > --- /dev/null > +++ b/hw/misc/k230_iomux.c > @@ -0,0 +1,124 @@ > [ ... skip 102 lines ... ] > +{ > + DeviceClass *dc = DEVICE_CLASS(klass); > + > + dc->desc = "Kendryte K230 IOMUX"; > + dc->vmsd = &vmstate_k230_iomux; > + device_class_set_legacy_reset(dc, k230_iomux_reset); Thank you for your contribution. This device_class_set_legacy_reset interface is deprecated, and RESETTABLE_CLASS is recommended instead. Other than that, I don't see any issues. I'd suggest rebasing it onto the latest master in the next version and including the base commit. LGTM! -- Junze Cao <[email protected]>