Re: [PATCH 48/56] disas/riscv: Move rv_op_illegal to riscv.c

On Sun, 2026-08-09 at 15:35 -0700, Richard Henderson wrote:
> illegal is no longer used in other files.
> 
> Signed-off-by: Richard Henderson <[email protected]>

Reviewed-by: Alistair Francis <[email protected]>

Alistair

> ---
>  disas/riscv.h | 4 ----
>  disas/riscv.c | 2 +-
>  2 files changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/disas/riscv.h b/disas/riscv.h
> index 241dd47d7f..5ac8c41616 100644
> --- a/disas/riscv.h
> +++ b/disas/riscv.h
> @@ -200,10 +200,6 @@ typedef struct {
>      uint8_t   rlist;
>  } rv_decode;
>  
> -enum {
> -    rv_op_illegal = 0
> -};
> -
>  /* instruction formats */
>  
>  #define rv_fmt_none                   "O\t"
> diff --git a/disas/riscv.c b/disas/riscv.c
> index 4141741d79..f0b3bc6be7 100644
> --- a/disas/riscv.c
> +++ b/disas/riscv.c
> @@ -29,7 +29,7 @@
>  #include "disas/riscv-xlrbr.h"
>  
>  typedef enum {
> -    /* 0 is reserved for rv_op_illegal. */
> +    rv_op_illegal = 0,
>      rv_op_lui = 1,
>      rv_op_auipc = 2,
>      rv_op_jal = 3,