[RFC PATCH 02/18] target/arm: Simplify invalid page test in allocation_tag_mem_internal
Richard Henderson <[email protected]>
| Newsgroups | org.nongnu.qemu-riscv,org.nongnu.qemu-arm,org.nongnu.qemu-devel |
|---|---|
| Message-ID | <[email protected]> |
Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Signed-off-by: Richard Henderson <[email protected]> --- target/arm/tcg/mte_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/tcg/mte_helper.c b/target/arm/tcg/mte_helper.c index a1d8618ddb..e3952fcabf 100644 --- a/target/arm/tcg/mte_helper.c +++ b/target/arm/tcg/mte_helper.c @@ -132,10 +132,10 @@ allocation_tag_mem_internal(CPUARMState *env, int ptr_mmu_idx, */ flags = probe_access_full(env, ptr, 0, ptr_access, ptr_mmu_idx, ra == 0, &host, &full, ra); - if (probe && (flags & TLB_INVALID_MASK)) { + if (unlikely(flags & TLB_INVALID_MASK)) { + assert(probe); return NULL; } - assert(!(flags & TLB_INVALID_MASK)); switch (full->extra.arm.pte_attrs) { case 0xf0: /* Tagged */ -- 2.43.0