Re: [RFC PATCH 07/18] accel/tcg: Replace size with first/last in probe_access_full
Philippe Mathieu-Daudé <[email protected]>
| Newsgroups | org.nongnu.qemu-riscv,org.nongnu.qemu-arm,org.nongnu.qemu-devel |
|---|---|
| Message-ID | <[email protected]> |
On 15/8/26 22:37, Richard Henderson wrote: > Signed-off-by: Richard Henderson <[email protected]> > --- > include/accel/tcg/probe.h | 2 +- > accel/tcg/cputlb.c | 17 +++++++++++------ > target/arm/tcg/helper-a64.c | 5 ++++- > target/arm/tcg/mte_helper.c | 21 ++++++++++++--------- > target/arm/tcg/sve_helper.c | 5 ++++- > target/mips/tcg/ldst_helper.c | 4 ++-- > 6 files changed, 34 insertions(+), 20 deletions(-) > > diff --git a/include/accel/tcg/probe.h b/include/accel/tcg/probe.h > index 0b788901ba..e3068a79de 100644 > --- a/include/accel/tcg/probe.h > +++ b/include/accel/tcg/probe.h > @@ -86,7 +86,7 @@ int probe_access_flags(CPUArchState *env, vaddr addr, int size, > * This function will return TLB_MMIO in order to force the access > * to be handled out-of-line if plugins wish to instrument the access. > */ > -int probe_access_full(CPUArchState *env, vaddr addr, int size, > +int probe_access_full(CPUArchState *env, vaddr addr, vaddr first, vaddr last, I prefer this clearer first/last range API, it feels safer. Missing updating the docstring, otherwise: Reviewed-by: Philippe Mathieu-Daudé <[email protected]> > MMUAccessType access_type, int mmu_idx, > bool nonfault, void **phost, > CPUTLBEntryFull **pfull, uintptr_t retaddr);