Re: [PATCH v3 31/49] monitor: change HMPCommand cmd to take MonitorHMP
"Jason J. Herne" <[email protected]>
| Newsgroups | org.nongnu.qemu-riscv,org.kernel.vger.kvm,org.nongnu.qemu-devel |
|---|---|
| Message-ID | <[email protected]> |
On 8/16/26 5:51 PM, Dr. David Alan Gilbert wrote: > * Marc-André Lureau ([email protected]) wrote: >> HMP commands are specific to the HMP monitor, so make the cmd function >> pointer in HMPCommand take MonitorHMP * instead of Monitor *. This >> strengthens type safety and makes the HMP-specific nature of these >> handlers explicit. >> >> Handler functions are renamed to take MonitorHMP *hmp, with a local >> Monitor *mon = MONITOR(hmp) added where the body needs the base type. >> Following patches will drop it, since most functions are HMP specific. >> >> Signed-off-by: Marc-André Lureau <[email protected]> > > Reviewed-by: Dr. David Alan Gilbert <[email protected]> > >> --- >> ... >> hw/s390x/s390-skeys.c | 5 +- >> hw/s390x/s390-stattrib.c | 6 +- Reviewed-by: Jason J. Herne <[email protected]>