Re: [PATCH v2 00/15] cpus: Constify @cpu in SysemuCPUOps::has_work() handler

On 20/8/26 22:13, Philippe Mathieu-Daudé wrote:
> Missing review: 2,12,14,15
> 
> Since v1:
>    - use _Generic (rth)
>    - no more RFC
> 
> - Patches 2-11 trivially add const qualifier for various
>    cpu_is/has() getters
> - Patch 12-14 add const-qualified variants of cpu_env(),
>    env_cpu(), and env_archcpu() using _Generic() macros;
>    consolidate the redundant env_cpu_const() alias and update
>    linux-user to use the generic accessor

After reworking _Generic from v1, this patchset ordering is not
bisectable anymore. Patches 12-14 must come first.

> - Patch 15 finally convert the SysemuCPUOps::has_work
>    hook and all target implementations.
> 
> No functional change; purely const-correctness improvment
> to enforce has_work() callees don't mutate CPUState.


> Philippe Mathieu-Daudé (15):
>    target/tricore: Document architectural interrupts as not implemented
>    system/cpus: Constify various CPUState arguments
>    target/avr: Constify CPUAVRState for some cpu_*() getters
>    target/hexagon: Constify CPUHexagonState in
>      hexagon_thread_is_enabled()
>    target/i386: Constify CPU*State for cpu_*_interrupt() getters
>    target/loongarch: Constify CPULoongArchState for various cpu_*()
>      getters
>    target/mips: Constify CPUMIPSState for various cpu_*() getters
>    target/s390x: Constify S390CPU for cpu_has_*() getters
>    target/riscv: Constify @iprio argument in riscv_cpu_pending_to_irq()
>    target/riscv: Constify CPURISCVState for various cpu_*() getters
>    target/sparc: Constify CPUSPARCState for various cpu_*() getters
>    linux-user: Uncast void pointer argument as Object in
>      target_cpu_free()
>    cpus: Add const-qualified CPU environment accessors
>    linux-user: Replace env_cpu_const() by generic env_cpu() equivalent
>    cpus: Constify @cpu in SysemuCPUOps::has_work() handler