Re: [PATCH 03/12] hw/arm/virt: use unique QOM name and target filter
Daniel P. Berrangé <[email protected]>
| Newsgroups | org.nongnu.qemu-riscv,org.nongnu.qemu-arm,org.nongnu.qemu-devel |
|---|---|
| Message-ID | <[email protected]> |
On Sun, Aug 23, 2026 at 11:07:21PM +0800, Yonggang Luo wrote:
> - Set TYPE_VIRT_MACHINE to MACHINE_TYPE_NAME("arm-virt") so ARM virt
> no longer collides with other virt-machine types in one process.
> - Register TYPE_TARGET_SPECIFIC with is_available = target_base_arm on
> the abstract parent.
> - Keep -machine virt via mc->alias on the latest versioned machine.
While this solves the headline QOM name clash today, it misses
the bigger picture - the arm virt machine is versioned:
$ qemu-system-aarch64 -M help | grep ^virt
virt-10.0 QEMU 10.0 ARM Virtual Machine
virt-10.1 QEMU 10.1 ARM Virtual Machine
virt QEMU 10.2 ARM Virtual Machine (alias of virt-10.2)
virt-10.2 QEMU 10.2 ARM Virtual Machine
virt-5.0 QEMU 5.0 ARM Virtual Machine (deprecated)
virt-5.1 QEMU 5.1 ARM Virtual Machine (deprecated)
virt-5.2 QEMU 5.2 ARM Virtual Machine (deprecated)
virt-6.0 QEMU 6.0 ARM Virtual Machine (deprecated)
virt-6.1 QEMU 6.1 ARM Virtual Machine (deprecated)
virt-6.2 QEMU 6.2 ARM Virtual Machine (deprecated)
virt-7.0 QEMU 7.0 ARM Virtual Machine (deprecated)
virt-7.1 QEMU 7.1 ARM Virtual Machine (deprecated)
virt-7.2 QEMU 7.2 ARM Virtual Machine (deprecated)
virt-8.0 QEMU 8.0 ARM Virtual Machine
virt-8.1 QEMU 8.1 ARM Virtual Machine
virt-8.2 QEMU 8.2 ARM Virtual Machine
virt-9.0 QEMU 9.0 ARM Virtual Machine
virt-9.1 QEMU 9.1 ARM Virtual Machine
virt-9.2 QEMU 9.2 ARM Virtual Machine
At some point the riscv64 virt machine is very likely to become
versioned too at which point all the versioned machines will
clash.
IOW, the change to unique naming needs to be applied to all virt
machine versions, not just the unversioned name.
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|