Re: [PATCH v2 01/13] hw/riscv/fdt-common, virt.c: add create_fdt_flash()

On 26/8/26 18:48, Daniel Henrique Barboza wrote:
> Add a common helper to create a cfi-flash compatible flash subnode.
> 
> This change only affects the existing 'virt' board for now but it will
> be used by the future 'riscv-server-ref' board in the future.
> 
> No FDT changes intended.
> 
> Signed-off-by: Daniel Henrique Barboza <[email protected]>
> ---
>   hw/riscv/fdt-common.c         | 12 ++++++++++++
>   hw/riscv/virt.c               | 18 ++----------------
>   include/hw/riscv/fdt-common.h |  1 +
>   3 files changed, 15 insertions(+), 16 deletions(-)


> diff --git a/include/hw/riscv/fdt-common.h b/include/hw/riscv/fdt-common.h
> index 1729a6abc6..6e438e0278 100644
> --- a/include/hw/riscv/fdt-common.h
> +++ b/include/hw/riscv/fdt-common.h
> @@ -36,4 +36,5 @@ void create_fdt_plic(void *fdt, hwaddr addr, uint64_t size,
>                        uint32_t cells_size, uint32_t ndev_sources,
>                        bool numa_enabled, int socket);
>   void riscv_pmu_generate_fdt_node(void *fdt, uint32_t cmask, char *pmu_name);
> +void create_fdt_flash(void *fdt, hwaddr flashbase, hwaddr flashsize);

Generic comment for the whole series, if you make this API public then
please prefix with 'riscv_' to avoid name clashes when linking with
distinct targets in the future.

>   #endif