Re: [PATCH v2 2/4] rust/hpet: add trace events

On Wed, Nov 19, 2025 at 03:51:58PM -0500, Stefan Hajnoczi wrote:
> Date: Wed, 19 Nov 2025 15:51:58 -0500
> From: Stefan Hajnoczi <[email protected]>
> Subject: [PATCH v2 2/4] rust/hpet: add trace events
> 
> Implement the same trace events as the C implementation.
> 
> Notes:
> - Keep order of hpet_ram_write_invalid_tn_cmp and hpet_ram_write_tn_cmp
>   the same as the C implementation.
> - Put hpet_ram_write_timer_id in HPETTimer::write() instead of
>   HPETState::decode() so that reads can be excluded.

Yes, these changes are accurate and clear.

> Signed-off-by: Stefan Hajnoczi <[email protected]>
> ---
>  rust/hw/timer/hpet/Cargo.toml    |  1 +
>  rust/hw/timer/hpet/meson.build   |  1 +
>  rust/hw/timer/hpet/src/device.rs | 45 +++++++++++++++++++-------------
>  3 files changed, 29 insertions(+), 18 deletions(-)

Reviewed-by: Zhao Liu <[email protected]>