Re: [PATCH 06/19] rust/qobject: add Serialize implementation
Paolo Bonzini <[email protected]>
| Newsgroups | org.nongnu.qemu-rust,org.nongnu.qemu-devel |
|---|---|
| Message-ID | <[email protected]> |
On 12/5/25 10:47, Markus Armbruster wrote:
>> + match_qobject! { (self) =>
>> + () => serializer.serialize_unit(),
>> + bool(b) => serializer.serialize_bool(b),
>> + i64(i) => serializer.serialize_i64(i),
>> + u64(u) => serializer.serialize_u64(u),
>> + f64(f) => serializer.serialize_f64(f),
>> + CStr(cstr) => cstr.to_str().map_or_else(
>> + |_| Err(ser::Error::custom("invalid UTF-8 in QString")),
>
> Could this be a programming error? Like flawed input validation?
Possibly, but given that you have to create a custom error type anyway,
I'd rather not special case this into the only abort (see the
"#![deny(clippy::unwrap_used)]" in patch 4).
Paolo