Re: [PATCH v2 7/8] rust/system: Stop exposing bogus DEVICE_NATIVE_ENDIAN symbol

Manos Pitsidianakis <[email protected]>
Newsgroups org.nongnu.qemu-rust,org.nongnu.qemu-arm,org.nongnu.qemu-devel
Message-ID <CAAjaMXZiYtyc1ucfs5hqxwqVFNNE-ebJeQvd4KZfZwdrBTegXg@mail.gmail.com>
On Wed, Dec 24, 2025 at 3:47 PM Philippe Mathieu-Daudé
<[email protected]> wrote:
>
> We want to remove the bogus DEVICE_NATIVE_ENDIAN definition
> (by only having it explicit, either big or little one). Stop
> exposing it to rust devices to avoid it spreading further.
>
> Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
> Reviewed-by: Richard Henderson <[email protected]>
> ---

Reviewed-by: Manos Pitsidianakis <[email protected]>

>  rust/system/src/memory.rs | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/rust/system/src/memory.rs b/rust/system/src/memory.rs
> index 4b3316bf767..4e06c16a0b5 100644
> --- a/rust/system/src/memory.rs
> +++ b/rust/system/src/memory.rs
> @@ -78,12 +78,6 @@ pub const fn little_endian(mut self) -> Self {
>          self
>      }
>
> -    #[must_use]
> -    pub const fn native_endian(mut self) -> Self {
> -        self.0.endianness = device_endian::DEVICE_NATIVE_ENDIAN;
> -        self
> -    }
> -
>      #[must_use]
>      pub const fn valid_sizes(mut self, min: u32, max: u32) -> Self {
>          self.0.valid.min_access_size = min;
> --
> 2.52.0
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.