Re: [PATCH v5 04/12] system/ram-discard-manager: implement replay via is_populated iteration
"David Hildenbrand (Arm)" <[email protected]> Fri, 5 Jun 2026 14:00:16 +0200
| Newsgroups | org.nongnu.qemu-rust,org.kernel.vger.kvm,org.nongnu.qemu-devel |
|---|---|
| Message-ID | <[email protected]> |
On 6/4/26 15:43, Marc-André Lureau wrote: > Replace the source-level replay wrappers with a new > replay_by_populated_state() helper that iterates the section at > min-granularity, calls is_populated() for each chunk, and aggregates > consecutive chunks of the same state before invoking the callback. > > This moves the iteration logic from individual sources into the manager, > preparing for multi-source aggregation where the manager must combine > state from multiple sources anyway. > > The replay_populated/replay_discarded vtable entries in > RamDiscardSourceClass are no longer called but remain in the interface > for now; they will be removed in follow-up commits along with the > now-dead source implementations. > > Reviewed-by: Peter Xu <[email protected]> > Signed-off-by: Marc-André Lureau <[email protected]> > --- Acked-by: David Hildenbrand <[email protected]> -- Cheers, David