Re: [PATCH v2 05/10] qom: Create object-property-ptr.[ch]

On Thu, Jun 11, 2026 at 01:54:54PM +0100, Mark Cave-Ayland wrote:
> > @@ -2141,4 +2048,10 @@ char *object_property_help(const char *name, const char *type,
> >   G_DEFINE_AUTOPTR_CLEANUP_FUNC(Object, object_unref)
> > +/*
> > + * Object property ptr helpers cannot be included at the beginning of the
> > + * file, because it depends on QOM definitions in current header.
> > + */
> > +#include "qom/object-property-ptr.h"
> 
> I wonder if possibly we might want to let the caller include the extra
> header? But I don't feel too strongly either way.

Yes, I didn't try to when drafting, but I also agree it's cleaner.  It will
need to update existing files (20 .c files) that used the api set.  I'll do
it if we can reach a consensus on the concept.

[...]

> Otherwise looks okay to me:
> 
> Reviewed-by: Mark Cave-Ayland <[email protected]>

Thanks,

-- 
Peter Xu