Re: [PATCH] rtl8139: Remove ineffective parameter
BALATON Zoltan <[email protected]>
| Newsgroups | org.nongnu.qemu-trivial,org.nongnu.qemu-devel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, 23 Feb 2026, Thomas Huth wrote: > On 12/02/2026 19.45, BALATON Zoltan wrote: >> On Tue, 27 Jan 2026, BALATON Zoltan wrote: >>> The do_interrupt parameter for rtl8139_do_receive was originally added >>> in commit 6cadb320c7 to avoid generating interrupt when receiving in >>> loopback mode. Later commit 5311fb805a changed this so that this >>> parameter became ineffective and now this parameter is unused and >>> always 1. If this turns out to be a problem maybe there's a better way >>> to fix this so remove the do_interrupt parameter for now to simplify >>> code. >> >> Ping? > > ... it's not a very complicated patch, so maybe this could also go via > qemu-trivial? (now on CC:) > > Anyway, > Reviewed-by: Thomas Huth <[email protected]> Thanks but too late, Philippe already took it via his hw misc pull request. Regards, BALATON Zoltan