Re: [PATCH v3 0/4] Fix a few minor issues reported by Coverity
"Sergei Heifetz" <[email protected]>
| Newsgroups | org.nongnu.qemu-trivial,org.nongnu.qemu-devel |
|---|---|
| Message-ID | <[email protected]> |
On Wed Mar 11, 2026 at 3:47 PM +05, Michael Tokarev wrote: > On 08.02.2026 13:39, Sergei Heifetz wrote: >> Hi. This patch series fixes several minor issues reported by our local >> Coverity installation. >> >> Changes in v3: >> - Nothing. I sent the second version of the series without the corresponding 'v2' >> suffix by mistake. I apologise. >> >> Changes in v2: >> - Remove assert(block) in system/physmem.c instead of placing it >> before the dereference. >> >> Sergei Heifetz (4): >> migration/savevm.c: reorder usage and assertion of mis->from_src_file >> dump/dump.c: reorder usage and assertion of block >> system/physmem.c: remove useless assertion of block >> hw/usb/core.c: reorder usage and assertion of p->ep > > Hi! > > I applied 3 patches from this series - all but the physmem.c one. > It's ugly either way, so I'm not picking it up. Sigh. I've just resubmitted the series with a change to the commit message of the `physmem.c` patch. As pointed out by Peter Maydell, there is a good reason to consider the assertion redundant. > Sorry it took so long. It's fine. Thank you.