Re: [PULL 00/14] Trivial patches for 2026-03-16

On 16.03.2026 13:15, Peter Maydell wrote:
[]
> Hi; this fails to build on some configs, eg:
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/13506360670
> 
> ../net/slirp.c:72:12: error: ‘get_last_str_sep’ defined but not used
> [-Werror=unused-function]
>     72 | static int get_last_str_sep(char *buf, int buf_size, const
> char **pp, int sep)
>        |            ^~~~~~~~~~~~~~~~
> 
> Looks like one of the patches defines the function unconditionally
> but puts the only callsite inside an ifdef, so if the config
> means we don't compile the code that calls it then the compiler
> complains about the unused function.

Yeah, -- I wondered about that too for a moment but didn't think about
it at the time.  I re-sent this pullreq with the problematic patch
dropped, the rest is the same.

Thanks, and sorry for the trouble.

/mjt