Re: [PATCH] hw/pci-host/raven: Fix crash when introspecting raven-pcihost from the CLI
Markus Armbruster <[email protected]>
| Newsgroups | org.nongnu.qemu-trivial,org.nongnu.qemu-devel |
|---|---|
| Message-ID | <[email protected]> |
Thomas Huth <[email protected]> writes: > From: Thomas Huth <[email protected]> > > QEMU currently crashes when introspecting raven-pcihost from the command > line interface: > > $ ./qemu-system-ppc -device raven-pcihost,help > Segmentation fault (core dumped) > > This happens because the raven_pcihost_initfn instance init function > calls get_system_memory(), but that is not available here yet. > > There does not seem to be a compelling reason for initializing the > memory regions from the instance init function, so let's simply move > the code into the realize() function instead to fix this issue. > > Signed-off-by: Thomas Huth <[email protected]> Tested-by: Markus Armbruster <[email protected]>