Re: [PATCH for-11.0.0] Fix include statement for u2f-emu.h

On Mon, 23 Mar 2026 at 17:22, Michael Tokarev <[email protected]> wrote:
>
> On 23.03.2026 20:12, Peter Maydell wrote:
>
> > Hi, Stefan. Could I ask you to try a tweak to your git config
> > which (assuming you use git-send-email) I hope will fix the problem
> > where the mailing list rewrites the From headers of your emails
> > to "Stefan Weil via qemu development <[email protected]>" and
> > then when a maintainer picks them up they need to manually adjust
> > the git commit author line ?
> >
> > This is the suggestion that our .mailmap has:
> >
> > # If the mailing list munges your emails, use:
> > #   git config sendemail.from '"Your Name" <[email protected]>'
> > # the use of "" in that line will differ from the typically unquoted
> > # 'git config user.name', which in turn is sufficient for 'git send-email'
> > # to add an extra From: line in the body of your email that takes
> > # precedence over any munged From: in the mail's headers.
> > # See https://lists.openembedded.org/g/openembedded-core/message/166515
> > # and https://lists.gnu.org/archive/html/qemu-devel/2023-09/msg06784.html
> >
> > Hopefully that will help...
>
> It might help if the original email did not have From: header at all.
> But I doubt that was the case here, as From-less emails (messages w/o
> From: header) gets dropped almost everywhere, so there should be
> delivery probs for other places too.

The point about the change is that it puts a From line in
the *body* of the email. git will pay attention to that if
it is there and ignore the incorrect email-header From: header.

> > (I don't really understand why our mailing list still does some
> > address rewriting -- I thought we had configured it so it never
> > changes the mails any more and so shouldn't need to rewrite senders,
> > but a few people still seem to have their addresses rewritten :-( )
>
> I guess most uses who's From addresses gets rewritten have DKIM set up.
> Your domain definitely does use DKIM signing, and so is mine.

Yeah, but the theory was that the mailing list should not need
to ever rewrite emails, regardless of whether DKIM is set up or not.

-- PMM