Re: [PATCH] hw/display/vga: Fix debug message

On Mon, 30 Mar 2026, Alex Bennée wrote:
> BALATON Zoltan <[email protected]> writes:
>
>> Fixes: f9b925fd41 vga: introduce VGADisplayParams
>> Signed-off-by: BALATON Zoltan <[email protected]>
>> ---
>>  hw/display/vga.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/display/vga.c b/hw/display/vga.c
>> index ee7d97b5c2..26039f0020 100644
>> --- a/hw/display/vga.c
>> +++ b/hw/display/vga.c
>> @@ -1662,7 +1662,7 @@ static void vga_draw_graphic(VGACommonState *s, int full_update)
>>
>>  #if 0
>>      printf("w=%d h=%d v=%d line_offset=%d cr[0x09]=0x%02x cr[0x17]=0x%02x linecmp=%d sr[0x01]=0x%02x\n",
>> -           width, height, v, line_offset, s->cr[9], s->cr[VGA_CRTC_MODE],
>> +           width, height, v, s->params.line_offset, s->cr[9], s->cr[VGA_CRTC_MODE],
>>             s->params.line_compare, sr(s, VGA_SEQ_CLOCK_MODE));
>>  #endif
>>      addr1 = (s->params.start_addr * 4);
>
> Really it would be worth just deleting the #if 0 code - if it's really
> useful for debugging you could turn it into a tracepoint.
>
> There are a bunch of other #if 0/#if DEBUG_* statements that could also
> be dumped/modernised.

Yes, it's useful for debugging (I used it to test frame buffer endianness) 
so probably should not be deleted. No, I don't want to overhaul and 
modernise the whole device and convert everything to trace points because 
as you say there's a bunch of those. So for now I just left it as it is 
and fixed the typo in it. I don't intend to do more work on this.

Regards,
BALATON Zoltan