Re: [PATCH trivial] util/meson.build: do not add cpuinfo-$arch to util_ss for 32bit CPUs
Philippe Mathieu-Daudé <[email protected]>
| Newsgroups | org.nongnu.qemu-trivial,org.nongnu.qemu-devel |
|---|---|
| Message-ID | <[email protected]> |
On 3/4/26 12:35, Michael Tokarev wrote: > On 25.03.2026 16:49, Michael Tokarev wrote: >> qemu dropped support for 32bit CPUs recently, so this change is an >> additional clean-up on top. But in theory it will allow building >> qemu-guest-agent on a 32bit system. >> >> Signed-off-by: Michael Tokarev <[email protected]> >> --- >> util/meson.build | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/util/meson.build b/util/meson.build >> index 33132c04ad..170e959d9b 100644 >> --- a/util/meson.build >> +++ b/util/meson.build >> @@ -116,13 +116,13 @@ endif >> if cpu == 'aarch64' >> util_ss.add(files('cpuinfo-aarch64.c')) >> -elif cpu in ['x86', 'x86_64'] >> +elif cpu == 'x86_64' >> util_ss.add(files('cpuinfo-i386.c')) >> elif cpu == 'loongarch64' >> util_ss.add(files('cpuinfo-loongarch.c')) >> -elif cpu in ['ppc', 'ppc64'] >> +elif cpu == 'ppc64' >> util_ss.add(files('cpuinfo-ppc.c')) >> -elif cpu in ['riscv32', 'riscv64'] >> +elif cpu = 'riscv64' > > This should be ==, not =. For 11.0, using '==': Reviewed-by: Philippe Mathieu-Daudé <[email protected]> For 11.1 we should simply rename the files using $target_base_arch suffix.