Re: [PATCH] hw/misc: Fix the valid access size to the avr-power device

Peter Maydell <[email protected]> Sun, 26 Apr 2026 13:58:10 +0100

Newsgroups	org.nongnu.qemu-trivial,org.nongnu.qemu-devel
Message-ID	<CAFEAcA8-TEcFd1bf+AmJL_zcmHmuE6=UxW5mndZK3kZ4orVJpg@mail.gmail.com>

On Sun, 26 Apr 2026 at 12:50, Michael Tokarev <[email protected]> wrote:
>
> On 21.04.2026 11:29, Thomas Huth wrote:
> > From: Thomas Huth <[email protected]>
> >
> > Accessing the device with in non-single byte mode currently causes
> > QEMU to abort:
> >
> >   $ echo "writew 0x800064 0x4142" | \
> >     ./qemu-system-avr -M mega2560 -display none -qtest stdio -accel qtest
> >   [I 0.000000] OPENED
> >   [R +0.001784] writew 0x800064 0x4142
> >   qemu-system-avr: ../../devel/qemu/hw/misc/avr_power.c:58: avr_mask_write:
> >    Assertion `offset == 0' failed.
> >   Aborted                    (core dumped)
> >
> > Set the valid max access size to 1 to fix the problem.
> >
> > Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3393
> > Signed-off-by: Thomas Huth <[email protected]>
>
> This looks like a minor issue, yet it feels like this change is a good
> candidate for the current stable releases.  Please let me know if it isn't.

Yes, this is fine for stable.

-- PMM