Re: [PATCH 2/5] hw/arm/fsl-imx8mp: Fix parent of ocram memory region

On Mon, 27 Apr 2026 at 13:09, Bernhard Beschow <[email protected]> wrote:
>
>
>
> Am 10. März 2026 10:00:31 UTC schrieb Peter Maydell <[email protected]>:
> >On Sun, 8 Mar 2026 at 20:35, Bernhard Beschow <[email protected]> wrote:
> >>
> >> Rather than having a NULL parent, let the containing SoC object be the
> >> parent. This cleans up the QOM composition tree a bit.
> >>
> >> Fixes:  ("hw/arm/fsl-imx8mp: Add on-chip RAM")
> >> cc: Gaurav Sharma <[email protected]>
> >> Signed-off-by: Bernhard Beschow <[email protected]>
> >> ---
> >>  hw/arm/fsl-imx8mp.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/hw/arm/fsl-imx8mp.c b/hw/arm/fsl-imx8mp.c
> >> index 0119a18416..839c925e4a 100644
> >> --- a/hw/arm/fsl-imx8mp.c
> >> +++ b/hw/arm/fsl-imx8mp.c
> >> @@ -671,7 +671,7 @@ static void fsl_imx8mp_realize(DeviceState *dev, Error **errp)
> >>                      fsl_imx8mp_memmap[FSL_IMX8MP_PCIE_PHY1].addr);
> >>
> >>      /* On-Chip RAM */
> >> -    if (!memory_region_init_ram(&s->ocram, NULL, "imx8mp.ocram",
> >> +    if (!memory_region_init_ram(&s->ocram, OBJECT(dev), "imx8mp.ocram",
> >>                                  fsl_imx8mp_memmap[FSL_IMX8MP_OCRAM].size,
> >>                                  errp)) {
> >>          return;
> >
> >
> >This is a migration break, because qemu_ram_set_idstr()
> >includes the qdev path of the owning device when it
> >creates the name of the ramblock for migrating it.
> >But since we haven't released anything with this change in
> >it and this board isn't versioned either, that's not a problem.
>
> Do we still need to catch that? If so, how?

The code change is fine; we just need to mention in the commit message
that it's a migration compat break but that it's OK to do that for this
board because it isn't versioned.

-- PMM