Re: [PATCH] hw/vfio: Drop superfluous inclusion of hw-error.h

On 4/28/26 18:37, Thomas Huth wrote:
> From: Thomas Huth <[email protected]>
> 
> None of these files use the hw_error() function, so there is no
> need to include hw-error.h here.
> 
> Signed-off-by: Thomas Huth <[email protected]>
> ---
>   hw/vfio/device.c      | 1 -
>   hw/vfio/helpers.c     | 1 -
>   hw/vfio/igd.c         | 1 -
>   hw/vfio/kvm-helpers.c | 1 -
>   4 files changed, 4 deletions(-)
> 
> diff --git a/hw/vfio/device.c b/hw/vfio/device.c
> index 3ffd69a579b..ccf14743e95 100644
> --- a/hw/vfio/device.c
> +++ b/hw/vfio/device.c
> @@ -24,7 +24,6 @@
>   #include "hw/vfio/vfio-device.h"
>   #include "hw/vfio/pci.h"
>   #include "hw/core/iommu.h"
> -#include "hw/core/hw-error.h"
>   #include "trace.h"
>   #include "qapi/error.h"
>   #include "qemu/error-report.h"
> diff --git a/hw/vfio/helpers.c b/hw/vfio/helpers.c
> index 65c6dba0428..c719864b92f 100644
> --- a/hw/vfio/helpers.c
> +++ b/hw/vfio/helpers.c
> @@ -24,7 +24,6 @@
>   
>   #include "exec/cpu-common.h"
>   #include "hw/vfio/vfio-device.h"
> -#include "hw/core/hw-error.h"
>   #include "qapi/error.h"
>   #include "vfio-helpers.h"
>   
> diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c
> index 6aacf27284f..e091f21b6a3 100644
> --- a/hw/vfio/igd.c
> +++ b/hw/vfio/igd.c
> @@ -16,7 +16,6 @@
>   #include "qapi/error.h"
>   #include "qapi/qmp/qerror.h"
>   #include "hw/core/boards.h"
> -#include "hw/core/hw-error.h"
>   #include "hw/nvram/fw_cfg.h"
>   #include "pci.h"
>   #include "pci-quirks.h"
> diff --git a/hw/vfio/kvm-helpers.c b/hw/vfio/kvm-helpers.c
> index d71c9590aaa..5e73dddc418 100644
> --- a/hw/vfio/kvm-helpers.c
> +++ b/hw/vfio/kvm-helpers.c
> @@ -25,7 +25,6 @@
>   #include "system/kvm.h"
>   #include "exec/cpu-common.h"
>   #include "hw/vfio/vfio-device.h"
> -#include "hw/core/hw-error.h"
>   #include "qapi/error.h"
>   #include "vfio-helpers.h"
>   


Applied to

     https://github.com/legoater/qemu vfio-next

Please base future contributions on this branch.

Thanks,

C.