Re: [PATCH net 3/8] batman-adv: stop tp_meter sessions during mesh teardown
Sven Eckelmann <[email protected]>
| Newsgroups | org.open-mesh.lists.batman,org.kernel.vger.netdev |
|---|---|
| Message-ID | <118589593.nniJfEyVGO@sven-desktop> |
On Friday, 8 May 2026 17:43:09 CEST Simon Wunderlich wrote: > From: Jiexun Wang <[email protected]> > > TP meter sessions remain linked on bat_priv->tp_list after the netlink > request has already finished. When the mesh interface is removed, > batadv_mesh_free() currently tears down the mesh without first draining > these sessions. > > A running sender thread or a late incoming tp_meter packet can then keep > processing against a mesh instance which is already shutting down. > Synchronize tp_meter with the mesh lifetime by stopping all active > sessions from batadv_mesh_free() and waiting for sender threads to exit > before teardown continues. Regarding the review under https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260508154314.12817-1-sw%40simonwunderlich.de The fix for this existing problem is planned for the second net PR - splitted due to the amount of patches. Besides this split, was not included in this one because I am waiting for the author to submit the v2 with my change request (to also fix the second occurrence of the invalid `atomic_dec_and_test`): https://patchwork.open-mesh.org/project/b.a.t.m.a.n./patch/df73e607bda0c84b22d64d80f8ac887190242baf.1778118303.git.rakukuip@gmail.com/ Regards, Sven
signature.asc
(application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQS81G/PswftH/OW8cVND3cr0xT1ywUCaf+CVgAKCRBND3cr0xT1 y72WAQDFVBUWAp8X7PrjoHI5CYUliUxo+U68UkaetrdQ2NlviwEAjXrfUF7sl2fU 8m2gEvsXHESwepGe/I1fVjZGMipanQ0= =MKqp -----END PGP SIGNATURE-----