[PATCH batadv v3 0/7] batman-adv: follow up fixes
Sven Eckelmann <[email protected]>
| Newsgroups | org.open-mesh.lists.batman |
|---|---|
| Message-ID | <[email protected]> |
While reviewing the fixes submitted to batman-adv in the recent weeks, further problems in similar or adjecent code was identified. This was either noticed in the manual review or reported by sashiko.dev. Especially in the TT code, you have the global and the local translation table. But when a bug was fixed, often only one of the two codepaths was fixed. It was now tried to sync the TVLV preparation code between to of them - not style wise but fixes wise. Besides the hardening, it will also make the code less confusing. The BLA and TP fixes are just some reference counting fixes - either reference leak fixes or missing reference handling. Signed-off-by: Sven Eckelmann <[email protected]> --- Changes in v3: - drop applied tp_meter + bla fixes (old patches 1-5) - add fix for the potential tp_meter receiver leak - Link to v2: https://patch.msgid.link/[email protected] Changes in v2: - keep initial num_vlan for TVLVs to avoid CONFIG_UBSAN_BOUNDS confusion - add patch to handle backbone_gw ref leak in batadv_bla_add_claim - add patch to switch last_changeset_len to unsigned type - add patch to avoid interaction with bonding code when checking for temporary loops in batadv_iv_ogm_process_per_outif() - also switch vlan_entries in batadv_tt_prepare_tvlv_local_data() to int - clarify batadv_bla_purge_claims() kref_get_unless_zero comment - drop netdev from To/Cc - Link to v1: https://patch.msgid.link/[email protected] --- Sven Eckelmann (7): batman-adv: tt: fix negative tt_buff_len batman-adv: tt: fix negative last_changeset_len batman-adv: tt: reject oversized local TVLV buffers batman-adv: tt: fix TOCTOU race for reported vlans batman-adv: tt: avoid empty VLAN responses batman-adv: tt: prevent TVLV entry number overflow batman-adv: tp_meter: fix tp_vars reference leak in receiver shutdown net/batman-adv/tp_meter.c | 13 +++++++-- net/batman-adv/translation-table.c | 55 +++++++++++++++++++++++++++++++------- net/batman-adv/types.h | 7 +++-- 3 files changed, 61 insertions(+), 14 deletions(-) --- base-commit: 05abe1217c5104b3514ef1945dacf511b012b921 change-id: 20260503-fixes-followup-064092b7ff55 Best regards, -- Sven Eckelmann <[email protected]>