Re: [PATCH batadv 2/5] batman-adv: only create hardif while a netdev is part of a mesh
Sven Eckelmann <[email protected]>
| Newsgroups | org.open-mesh.lists.batman |
|---|---|
| Message-ID | <12908485.O9o76ZdvQC@sven-desktop> |
On Saturday, 31 May 2025 11:52:12 CEST Sven Eckelmann wrote:
> On Monday, 19 May 2025 22:46:29 CEST Matthias Schiffer wrote:
> > -int batadv_hardif_enable_interface(struct batadv_hard_iface *hard_iface,
> > +int batadv_hardif_enable_interface(struct net_device *net_dev,
> > struct net_device *mesh_iface)
> > {
> [....]
> > + hard_iface->wifi_flags = batadv_wifi_flags_evaluate(net_dev);
>
> Moving this here should break the WIFI TT flag in scenarios like this:
>
> ┌──────┐
> ┌───────────┼br-lan├──────┐
> │ └──────┘ │
> │ │
> │ │
> ┌─▼─┐ ┌──▼─┐
> │ap0│ │bat0│
> └───┘ └──┬─┘
> │
> │
> ┌──▼──┐
> │mesh0│
> └─────┘
>
>
> ap0 is not the lower interface of any batadv mesh interface but TT ap
> isolation is depending on the information stored for this hardif. See:
I have now posted
https://patchwork.open-mesh.org/project/b.a.t.m.a.n./patch/[email protected]/
to separate the wifi flags from the code (around batadv_hardif) which you
try to modify.
Regards,
Sven
signature.asc
(application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQS81G/PswftH/OW8cVND3cr0xT1ywUCagCPRgAKCRBND3cr0xT1 y46sAQD3azTP2Zt3AIXcte4zCOa8HZ9gfCHylcX1KiI3zGR7lwD+PKHNKb8DZv8h 0yE/8Hj074yAJY8HmjkjX3YtFVpszAM= =HFr4 -----END PGP SIGNATURE-----