Re: [PATCH RFC batadv] batman-adv: tvlv: enforce 2-byte alignment
Sven Eckelmann <[email protected]> Sun, 14 Jun 2026 10:57:07 +0200
| Newsgroups | org.open-mesh.lists.batman |
|---|---|
| Message-ID | <12932148.O9o76ZdvQC@sven-desktop> |
On Sunday, 14 June 2026 10:19:54 CEST Sven Eckelmann wrote:
> The fields of an aggregated OGM(v2) are accessed assuming (at least) 2-byte
> alignment, so a following OGM must start at an even offset. As the header
> length is even, an odd tvlv_len would misalign it and trigger unaligned
> accesses on strict-alignment architectures.
>
> Such a misaligned TVLV/OGM/OGMv2 is not created by a normal participant in
> the mesh. Therefore, reject such malformed packets.
>
> Fixes: 0b6aa0d43767 ("batman-adv: tvlv - basic infrastructure")
> Signed-off-by: Sven Eckelmann <[email protected]>
> ---
batadv_recv_mcast_packet will be added in v2.
signature.asc
(application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQS81G/PswftH/OW8cVND3cr0xT1ywUCai5s4wAKCRBND3cr0xT1 y3oYAQCDMJBITdYQN4vZgcLo+crQ7Gy5Gr857eLsyFLvVF15AwEAr7pWjyzTJ1Qa rNuBWJJNrmNrH0BoQESuxP9kAnM7tAk= =lXSf -----END PGP SIGNATURE-----