Re: [PATCH RFC batadv v3 0/6] batman-adv: tt: atomic sashiko fixes

On Wednesday, 5 August 2026 17:09:34 CEST Sven Eckelmann wrote:
> There were a couple of sashiko reports regarding the
> batadv-next-pullrequest-20260728 PR. I went through the TT code and tried
> to handle them and at the same time already predict what else sashiko might
> report as next. I needed to change the batadv_tt_local_remove() hash
> interaction as preparation for the related NEW flag (and counter) handling.
> 
> And the netdev maintainers rejected this approach (for now). I had to
> re-add the atomic_t code parts back in this patchset. But since the netdev
> maintainers didn't like the atomic_t implementation, everything was changed
> to atomic_t with the help of scoped_guard().
> 
> Signed-off-by: Sven Eckelmann <[email protected]>
> ---
> Changes in v3:
> - switched to spinlock_bh due to rejection atomic_t by netdev (and
>   potentially easier code)

Mixed up some corner case flag handling while converting it back from atomic_t 
to the original simple handling. My bad but easy to fix in v4.

But it is more problematic that the cleanup.h states:

 * Lastly, given that the benefit of cleanup helpers is removal of
 * "goto", and that the "goto" statement can jump between scopes, the
 * expectation is that usage of "goto" and cleanup helpers is never
 * mixed in the same function. I.e. for a given routine, convert all
 * resources that need a "goto" cleanup to scope-based cleanup, or
 * convert none of them.

I am not 100% sure how to deal with this at the moment

Regards,
	Sven

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQS81G/PswftH/OW8cVND3cr0xT1ywUCanOFAwAKCRBND3cr0xT1
y4pNAQD/H8A9O7Xd5bG6fAtYHlIal08xiQ8V2CtoAHB1AMu6cQD/RoXpURmDzPpn
oQmpjv/Y8ynM1KqYdjQz8MnbuJdRVw8=
=PY7N
-----END PGP SIGNATURE-----