[PATCH RFC batadv 00/12] batman-adv: tt: refactor *_add/batadv_tt_local_remove functions
Sven Eckelmann <[email protected]>
| Newsgroups | org.open-mesh.lists.batman |
|---|---|
| Message-ID | <[email protected]> |
While workig on the flag protection changes, it became apparent that the current code is hard to maintain. Too many gotos with large sections which are hard to cras; because it is unclear how these sections are interact. To simplify everything, sections which are handling a single task are extracted in separate functions. This makes it cleared what the input and output of each "section" are. I tought about moving this in front of the flag protection changes but I might end up in an endless "first clean up this other thing over there"-loop before actually integrating the relevant changes. Signed-off-by: Sven Eckelmann <[email protected]> --- Sven Eckelmann (12): batman-adv: tt: look up wifi state of incoming interface in helper batman-adv: tt: extract allocation of new local entries batman-adv: tt: replace forward gotos in batadv_tt_local_add() batman-adv: tt: extract refresh of existing local entries batman-adv: tt: extract update of dynamic client flags batman-adv: tt: extract allocation of new global entries batman-adv: tt: extract merging of flags into existing global entries batman-adv: tt: replace add_orig_entry goto in batadv_tt_global_add() batman-adv: tt: extract removal of the superseded local entry batman-adv: tt: extract marking of a removed local entry batman-adv: tt: extract immediate purge of a local entry batman-adv: tt: drop the cleanup label from batadv_tt_local_remove() net/batman-adv/translation-table.c | 720 +++++++++++++++++++++++-------------- 1 file changed, 450 insertions(+), 270 deletions(-) --- base-commit: 46e983472304d8875436a23ccb996ea18856081a change-id: 20260806-tt-add-cleanup-10b53e9e657b prerequisite-change-id: 20260730-tt-fixes-fca2b722ebbd:v4 prerequisite-patch-id: 8c512768c6b45c3df367b37240f13c82b9c0b073 prerequisite-patch-id: d6522440ee88ce12d7109c9afe31eae8f0ec7358 prerequisite-patch-id: 659ae36c803f6348748ae4bc34d5b59c54bca267 prerequisite-patch-id: 023ee98093cfa05e842261bf895e5f3b4e38e49a prerequisite-patch-id: 58431a16185a5819aa0d6e3b57f2d77e83bca755 prerequisite-patch-id: 14b8822e6f82a825b4d5b26d61003c9c4923cd7e prerequisite-patch-id: 1b1fcf21a580983f652735dfe4bc99ed67ca69dc prerequisite-patch-id: 7fbb101bc6b6924d631888aae052501ce724ce9f Best regards, -- Sven Eckelmann <[email protected]>