[PATCH batadv 0/3] batman-adv: bat_v: fix bonding candidate selection

Sven Eckelmann <[email protected]>
Newsgroups org.open-mesh.lists.batman
Message-ID <[email protected]>
batadv_v_neigh_is_sob() implements the metric (throughput) similarity check
as:

  neigh2 (the reference) has a better throughput than 3/4 of the neigh1
  (candidate) throughput

But this results in a selection of bonding candidates in
batadv_find_router() which have a really low throughput. But the goal must
be to select candidates which have a good throughput.

The neigh1/neigh2 operands must be swapped in the comparison to use the
reference as such and select only neighbor+interface combinations with good
throughput.

To make the code more readable, use the names "candidate" and "reference"
instead of "neigh1" + "neigh2".

See https://www.open-mesh.org/issues/464

Signed-off-by: Sven Eckelmann <[email protected]>
---
Sven Eckelmann (3):
      batman-adv: bat_v: fix bonding candidate selection
      batman-adv: clarify cut-off in batadv_v_neigh_is_sob kernel-doc
      batman-adv: use more descriptive var names for is_similar_or_better

 net/batman-adv/bat_iv_ogm.c | 25 +++++++++++++------------
 net/batman-adv/bat_v.c      | 42 +++++++++++++++++++++---------------------
 net/batman-adv/types.h      | 12 ++++++------
 3 files changed, 40 insertions(+), 39 deletions(-)
---
base-commit: 6ff21902725ca4c437f6d60774e903ecdca2e645
change-id: 20260806-bat_v-sob-kdoc-d04980e285d9

Best regards,
--  
Sven Eckelmann <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.