Re: [bitbake-devel] [PATCH 1/4] bitbake-setup: update vscode workspace always

On Tue, 2026-04-07 at 20:30 +0200, Alexander Kanavin via
lists.openembedded.org wrote:
> On Mon, 6 Apr 2026 at 22:24, Adrian Freihofer via
> lists.openembedded.org
> <[email protected]> wrote:
> >      logger.plain("\nConfiguration in {} has not
> > changed.".format(setupdir))
> > +    if update:
> > +        workspace_file = os.path.join(setupdir, "bitbake.code-
> > workspace")
> > +        if os.path.exists(workspace_file):
> > +            bitbake_builddir = os.path.join(setupdir, "build")
> > +            configure_vscode(setupdir, layerdir, bitbake_builddir,
> > os.path.join(bitbake_builddir, "init-build-env"))
> 
> Will this do the update quietly or inform the user that vscode
> workspace is being synced with local changes even though no
> configuration updates have been detected?

The configure_vscode function preserves user-customized VSCode
configurations and it enforces essential settings required for proper
functionality. That means, executing configure_vscode should not harm
and hence it should be fine to just run it always (when "which code" is
true).

Having this as a separate command looks like more complicated for the
user. Expecting that the user always does something like

  bitbake-setup update
  bitbake-setup update-vscode-workspace

would be inconvenient. Most probably the user would just not run the
second command and end up with an inconsistent environment which can be
very annoying.

Or do you mean a separate command in addition to calling the
configure_vscode function in init and update? That would then lead to
the question when the user should run bitbake-setup update-vscode-
workspace. After init? After update? Or just if update does nothing but
the VSCode configuration needs an update?
Having only bitbake-setup update to update what ever might needs an
update, looks at least simple to me. But I agree, a separate command
could work as well.

Maybe this patch is not very important if bitbake-setup itself does not
change anymore. Might be that I thought this should be improved when
working on bitbake-setup itself, which is a very special use case.

Thanks for the quick feedback
Adrian

> 
> Perhaps this should be its own command rather, something like
> 'update-vscode-workspace' ?
> 
> Alex
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#19351):
> https://lists.openembedded.org/g/bitbake-devel/message/19351
> Mute This Topic: https://lists.openembedded.org/mt/118697281/4454582
> Group Owner: [email protected]
> Unsubscribe:
> https://lists.openembedded.org/g/bitbake-devel/unsub [[email protected]
> ]
> -=-=-=-=-=-=-=-=-=-=-=-