RE: [bitbake-devel][PATCH V2 2/5] fetch2/wget.py: add filter_regex parameter to latest_versionstring

I'll add note and simplify the function calls.

Regards,
Qi

-----Original Message-----
From: Alexander Kanavin <[email protected]> 
Sent: Thursday, May 7, 2026 6:43 PM
To: Chen, Qi <[email protected]>
Cc: [email protected]; MacLeod, Randy <[email protected]>
Subject: Re: [bitbake-devel][PATCH V2 2/5] fetch2/wget.py: add filter_regex parameter to latest_versionstring

On Thu, 7 May 2026 at 08:19, <[email protected]> wrote:
> +                if filter_regex:
> +                    if not re.match(filter_regex, re.sub('_', '.', newver[1])):

This needs to include a note explaining that filter_regex is derived from PV, and so uses . as separator, while upstream may be using _ as separator (as seen below in the code where the same conversion happens before the discovered version is returned).

> -                            package, package_regex, current_version, ud, d)
> +                            package, package_regex, current_version, 
> + ud, d, filter_regex=filter_regex)

Here and in other places you can perhaps simply pass in filter_regex without naming the argument?

Alex