[PATCH v3 0/3] doc: bitbake-user-manual-metadata: clarify inherit_defer documentation
Dawid Bijak <[email protected]>
| Newsgroups | org.openembedded.lists.bitbake-devel,org.yoctoproject.lists.docs |
|---|---|
| Message-ID | <[email protected]> |
v3 of a series addressing a few inaccuracies I came across while reading the inherit_defer documentation.
1)
Drop the claim that "If VARNAME is going to be set, it needs to be set before the inherit_defer statement is parsed"
which is wrong and defeats the purpose of inherit_defer.
The whole point of deferred evaluation is that assignments made after the directive are taken into account.
2)
Drop the anonymous Python example of assigning the class name from an anonymous Python function, which does not work:
python () {
if d.getVar('SOMETHING') == 'value':
d.setVar('VARIABLE', 'someclass')
else:
d.setVar('VARIABLE', '')
}
inherit_defer ${VARIABLE}
inherit_defer is resolved before anonymous Python functions run, so ${VARIABLE} always expands to empty
and the inherit is a no-op.
add a warning explaining that using a anonymous python has no effect
on the inherit_defer
3)
Add a short explanation of how inherit_defer interacts with conditional overrides, and rename VARNAME to
VARIABLE for consistency with the rest of documentation.
Changes since v2:
- Link to v2: [2]
- Picked up Quentin's Reviewed-by for patch 1 from [3]
- Applied Quentin's suggestion from [4] and added Suggested-by:
Quentin to patch 2
- Renamed VARNAME to VARIABLE as suggested by Quentin in [5] in
patch 3
- Dropped patch 4 following NACK in [6]
Changes since v1:
- Link to v1: [1]
- Split single patch into four
- Shorten the override example explanation
- Drop the "footgun" example from the previous patch
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
[3] https://lore.kernel.org/all/[email protected]/
[4] https://lore.kernel.org/all/[email protected]/
[5] https://lore.kernel.org/all/[email protected]/
[6] https://lore.kernel.org/all/[email protected]/
Greets,
Dawid
Dawid Bijak (3):
doc: bitbake-user-manual-metadata: remove incorrect claim
doc: bitbake-user-manual-metadata: remove invalid anonymous Python
example
doc: bitbake-user-manual-metadata: explain inherit_defer example
.../bitbake-user-manual-metadata.rst | 28 +++++++++----------
1 file changed, 14 insertions(+), 14 deletions(-)
--
2.48.1