Re: [bitbake-devel] [PATCH 1/1] data_smart: fix operations lost when an override name contains a variable
Richard Purdie <[email protected]> Sun, 26 Jul 2026 21:11:48 +0100
| Newsgroups | org.openembedded.lists.bitbake-devel |
|---|---|
| Message-ID | <31e8eeb405240dac2aa53d750a5253e55e6eaabd.camel@linuxfoundation.org> |
On Sun, 2026-07-26 at 21:53 +0700, Minh Ti=E1=BA=BFn Nguy=E1=BB=85n wrote: > > I think this is because expandKeys() calls renameVar and then > > renameVar itself also calls renameVar() on the same element, which > > breaks things. [...] then I think that resolve the issue? >=20 > Yes, it does, and it is the better fix. Both keys are already in the > todolist with their expanded names, so expandKeys() can rename them > both. My patch only worked around the second rename with expand(). >=20 > I tested your diff on a fresh clone at c251833d2. It fixes the exact > form from the bug report, :prepend and :remove, a conditional override > with no operation keyword, several variables in one override name, and a > variable in the key as well as in the override name, all of which fail > on master. bb.tests.data passes, oe-core parses clean at 952 recipes > with no new warnings, and both v1 test cases pass on your diff unchanged. I have to wonder whether my reply is just being fed to AI? :/ The project's policy is that AI use isn't prohibited but it's use should be made clear... Cheers, Richard