Re: [bitbake-devel] [PATCH v2] bitbake-worker: Evaluate exported_vars() before emptying the environment

Richard Purdie <[email protected]> Wed, 29 Jul 2026 09:01:28 +0100
Newsgroups org.openembedded.lists.bitbake-devel
Message-ID <f72749cd66f1f9783ceea7586da2320d06c5b3d4.camel@linuxfoundation.org>
On Wed, 2026-07-29 at 01:28 +0100, Alejandro Mery wrote:
> On 28/07/2026 22:15, Richard Purdie wrote:
> > On Mon, 2026-07-27 at 17:28 +0000, Alejandro Mery via lists.openembedde=
d.org wrote:
> >=20
> > I did a bit more research and thinking about this and I think I
> > might
> > suggest a new approach. I've noticed that this is the only user of
> > exported_vars() in the codebase, so perhaps we just stop returning
> > a
> > generator?
> >=20
> > It does appear to be causing a lot more problems than it solves,
> > particularly if we just turn it into a list anyway!
> >=20
> > If we change things that way, it seems much more unlikely we can
> > break
> > it in future and the need for the comments is removed.
> >=20
> > Does that seem reasonable? Sorry about the change in direction but
> > this
> > patch just doesn't look/feel right now I realise there is only one
> > user
> > of the function.
>=20
> absolutely. I blindly assumed you wanted it to be a generator.
>=20
> so, for v3 exported_vars() returns a materialised list. what would
> you want the tests t do?

We probably don't need the test case now the problem we were trying to
protect against isn't there.

Thanks,

Richard