RE: [bitbake-devel] [PATCH] runqueue: Fix pending_hash_index not including taskname

"[email protected]" <[email protected]>
Newsgroups org.openembedded.lists.bitbake-devel
Message-ID <DM8PR12MB54309E7F72B6CC078D0D6BA58BA02@DM8PR12MB5430.namprd12.prod.outlook.com>
> > The intention was probably not to use the literal string, "taskname"
> >
> > Signed-off-by: Chris Laplante <[email protected]>
> > ---
> >  lib/bb/runqueue.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py index
> > a4689e134..544081053 100644
> > --- a/lib/bb/runqueue.py
> > +++ b/lib/bb/runqueue.py
> > @@ -84,7 +84,7 @@ def pending_hash_index(tid, rqdata):
> >      (mc, fn, taskname, taskfn) = split_tid_mcfn(tid)
> >      pn = rqdata.dataCaches[mc].pkg_fn[taskfn]
> >      h = rqdata.runtaskentries[tid].unihash
> > -    return pn + ":" + "taskname" + h
> > +    return pn + ":" + taskname + h
> >
> >  class RunQueueStats:
> >      """
> 
> Yes, that looks like a fun bug. Was that breaking multiconfig?

As far as I can tell, it didn't break anything, and I'm not sure why. The code has been like this since 2019, commit a75c5fd6d4. 

I guess the hash was saving us.

Thanks,
Chris
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.