Re: [meta-multimedia][PATCH] libcamera: add libdrm dependency

Kieran Bingham <[email protected]>
Newsgroups org.openembedded.lists.openembedded-devel
Message-ID <[email protected]>
Hi Markus,

Quoting Markus Volk (2026-07-13 10:17:56)
> This fixes an issue seeen if 'glvnd' is in DISTRO_FEATURES:
> | FAILED: [code=1] src/libcamera/libcamera.so.0.7.1.p/egl.cpp.o
> | x86_64-oe-linux-g++ -m64 -march=nehalem -mtune=generic -mfpmath=sse -msse4.2 -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/home/flk/bitbake/bitbake-builds/oe/build/tmp/work/corei7-64-oe-linux/libcamera/0.7.1/recipe-sysroot -Isrc/libcamera/libcamera.so.0.7.1.p -Isrc/libcamera -I../sources/libcamera-0.7.1/src/libcamera -Iinclude -I../sources/libcamera-0.7.1/include -Iinclude/libcamera -Iinclude/libcamera/ipa -Iinclude/libcamera/internal -Isrc/libcamera/proxy -I/home/flk/bitbake/bitbake-builds/oe/build/tmp/work/corei7-64-oe-linux/libcamera/0.7.1/recipe-sysroot/usr/include/p11-kit-1 -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c++20 -Wnon-virtual-dtor -Wno-redundant-move -Wmissing-declarations -Wshadow -include /home/flk/bitbake/bitbake-builds/oe/build/tmp/work/corei7-64-oe-linux/libcamera/0.7.1/build/config.h -O2 -g -fcanon-prefix-map -ffile-prefix-map=/home/flk/bitbake/bitbake-builds/oe/build/tmp/work/corei7-64-oe-linux/libcamera/0.7.1/sources/libcamera-0.7.1=/usr/src/debug/libcamera/0.7.1 -ffile-prefix-map=/home/flk/bitbake/bitbake-builds/oe/build/tmp/work/corei7-64-oe-linux/libcamera/0.7.1/build=/usr/src/debug/libcamera/0.7.1 -ffile-prefix-map=/home/flk/bitbake/bitbake-builds/oe/build/tmp/work/corei7-64-oe-linux/libcamera/0.7.1/recipe-sysroot= -ffile-prefix-map=/home/flk/bitbake/bitbake-builds/oe/build/tmp/work/corei7-64-oe-linux/libcamera/0.7.1/recipe-sysroot-native= -pipe -fvisibility-inlines-hidden -Wno-error=array-bounds -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/libcamera/libcamera.so.0.7.1.p/egl.cpp.o -MF src/libcamera/libcamera.so.0.7.1.p/egl.cpp.o.d -o src/libcamera/libcamera.so.0.7.1.p/egl.cpp.o -c ../sources/libcamera-0.7.1/src/libcamera/egl.cpp
> | ../sources/libcamera-0.7.1/src/libcamera/egl.cpp:22:10: fatal error: libdrm/drm_fourcc.h: No such file or directory
> |    22 | #include <libdrm/drm_fourcc.h>
> |       |          ^~~~~~~~~~~~~~~~~~~~~
> 

libcamera doesn't actually depend on libdrm but this egl.cpp shouldn't
point to libdrm/drm_fourcc as we have a local copy of this header in the
libcamera project.

https://gitlab.freedesktop.org/camera/libcamera/-/blob/master/include/linux/drm_fourcc.h?ref_type=heads

This incorrect dependency was fixed in 

https://gitlab.freedesktop.org/camera/libcamera/-/commit/b9302237231471c043bb102dd8dc045fa05eb983

which is integrated in libcamera-0.7.2.

Perhaps rather than add an incorrect dependency, we could backport the
patch for the recipe or bump to libcamera-0.7.2?

Regards
--
Kieran

> Signed-off-by: Markus Volk <[email protected]>
> ---
>  meta-multimedia/recipes-multimedia/libcamera/libcamera_0.7.1.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.7.1.bb b/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.7.1.bb
> index 2b351a39be..68b2c6648c 100644
> --- a/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.7.1.bb
> +++ b/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.7.1.bb
> @@ -17,7 +17,7 @@ SRCREV = "183e37362f57ff3ce7493abf0bc6f1b57b931f55"
>  
>  PE = "1"
>  
> -DEPENDS = "python3-pyyaml-native python3-jinja2-native python3-ply-native python3-jinja2-native udev gnutls chrpath-native libevent libyaml"
> +DEPENDS = "python3-pyyaml-native python3-jinja2-native python3-ply-native python3-jinja2-native udev gnutls chrpath-native libevent libyaml libdrm"
>  DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'qt', 'qtbase qtbase-native', '', d)}"
>  
>  PACKAGES =+ "${PN}-compliance ${PN}-gst ${PN}-pycamera"
> -- 
> 2.55.0
> 
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.