Re: [oe] [PATCH] redis: fix build of the bundled xxHash with -Og
Ricardo Salveti <[email protected]>
| Newsgroups | org.openembedded.lists.openembedded-devel |
|---|---|
| Message-ID | <CAA_5yovr5sZQsNtCR5B1kOAieUndWwzj+54i26ELHiG5CSO-Ng@mail.gmail.com> |
On Sun, Aug 16, 2026 at 7:48 PM Khem Raj <[email protected]> wrote: > On Sun, Aug 16, 2026 at 9:40 AM Ricardo Salveti via lists.openembedded.org <[email protected]> wrote: > > I see that its fixed in xxhash recipe in oe-core > > CFLAGS += "${@bb.utils.contains('SELECTED_OPTIMIZATION', '-Og', '-DXXH_NO_INLINE_HINTS', '', d)}" Indeed, I can do a v2 copying over the same line from oe-core. > I wonder if its better to depend on system xxhash instead of using vendored > version. Please explore if that option is possible. There are a few issues with this since it is not based on the exact 0.8.3 release (it is post release), and it could cause potential dependency issues in the future. The other issue is that there is no logic in redis to consume it as an external dependency, so it would be another patch we would have to carry which will probably not be accepted upstream. Technically possible, but it will potentially add more work to maintain the recipe moving forward (while the CFLAGS line is a one-liner). What do you think? Thanks, Ricardo