Re: [oe] [PATCH] redis: fix build of the bundled xxHash with -Og

On Mon, Aug 17, 2026 at 5:48 PM Khem Raj <[email protected]> wrote:
> On Mon, Aug 17, 2026 at 12:50 PM Ricardo Salveti via lists.openembedded.org <[email protected]> wrote:
>>
>> On Sun, Aug 16, 2026 at 7:48 PM Khem Raj <[email protected]> wrote:
>> > On Sun, Aug 16, 2026 at 9:40 AM Ricardo Salveti via lists.openembedded.org <[email protected]> wrote:
>> >
>> > I see that its fixed in xxhash recipe in oe-core
>> >
>> > CFLAGS += "${@bb.utils.contains('SELECTED_OPTIMIZATION', '-Og', '-DXXH_NO_INLINE_HINTS', '', d)}"
>>
>> Indeed, I can do a v2 copying over the same line from oe-core.
>>
>> > I wonder if its better to depend on system xxhash instead of using vendored
>> > version. Please explore if that option is possible.
>>
>> There are a few issues with this since it is not based on the exact
>> 0.8.3 release (it is post release), and it could cause potential
>> dependency issues in the future. The other issue is that there is no
>> logic in redis to consume it as an external dependency, so it would be
>> another patch we would have to carry which will probably not be
>> accepted upstream.
>
> I wanted to know if there is a configure time option to easily use system version
> or vendored version of xxhash library. It seems there is not, can you confirm ?
> if thats the case then just send the patch ported from xxhash oe-core recipe.

There is no option because the source is available as a vendor
dependency, we would have to add that. Just sent V2 then.

Thanks,

Ricardo