Re: [Intel-wired-lan] [PATCH iwl-net v3 3/3] ice: Cache struct ice_hw pointer for split register reads

> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of Sergey Temerkhanov
> Sent: 01 June 2026 14:50
> To: [email protected]
> Cc: [email protected]
> Subject: [Intel-wired-lan] [PATCH iwl-net v3 3/3] ice: Cache struct ice_hw pointer for split register reads
>
> Cache the primary ice_hw pointer to ensure consistency between calls (both parts of a value will be read from the same NAC).
> ice_get_primary_hw() will never return NULL, but during the ctrl_pf cleanup there may be a case when one call will return the pointer to the ctrl_pf->hw and the subsequent one - to the
> pf->hw which generally are not the same.
> Struct ice_hw is embedded in the struct ice_pf so it is protected by the same critical section - no additional synchronization is needed.
>
> Fixes: e2193f9f9ec9 ("ice: enable timesync operation on 2xNAC E825 devices")
> Signed-off-by: Sergey Temerkhanov <[email protected]>
> Reviewed-by: Aleksandr Loktionov <[email protected]>
> Reviewed-by: Arkadiusz Kubalewski <[email protected]>
> Tested-by: Frederick Lawler <[email protected]>
> ---
> drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>

Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)