Re: [Intel-wired-lan] [PATCH iwl-next v1] igb: remove ASSERT_RTNL() from igb_write_rss_key()
Simon Horman <[email protected]> Mon, 20 Jul 2026 11:20:42 +0100
| Newsgroups | org.osuosl.intel-wired-lan,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Sat, Jul 11, 2026 at 10:32:15PM +0900, Takashi Kozu wrote:
> igb_runtime_resume() calls __igb_resume() with rpm=true, which
> skips rtnl_lock() to avoid deadlocks. On that path __igb_open()
> -> igb_configure() -> igb_setup_mrqc() -> igb_write_rss_key()
> runs without rtnl held, so ASSERT_RTNL() fires a false-positive
> WARN on every runtime resume. Drop it.
Hi Takashi,
I think this patch description needs to explain why
it is safe to run igb_write_rss_key() without holding RTNL.
>
> Fixes: dfaf57ef99cf ("igb: prepare for RSS key get/set support")
> Signed-off-by: Takashi Kozu <[email protected]>
...