Re: [Intel-wired-lan] [PATCH iwl-next v3 1/2] idpf: remove conditional MBX deinit from idpf_vc_core_deinit()

> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Emil Tantilov
> Sent: Tuesday, June 30, 2026 4:19 PM
> To: [email protected]
> Cc: [email protected]; Kitszel, Przemyslaw
> <[email protected]>; Bhat, Jay <[email protected]>; Barrera,
> Ivan D <[email protected]>; Loktionov, Aleksandr
> <[email protected]>; Zaremba, Larysa
> <[email protected]>; Nguyen, Anthony L
> <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; Lobakin, Aleksander <[email protected]>;
> [email protected]; Chittim, Madhu <[email protected]>;
> [email protected]; [email protected]; [email protected];
> [email protected]
> Subject: [Intel-wired-lan] [PATCH iwl-next v3 1/2] idpf: remove conditional
> MBX deinit from idpf_vc_core_deinit()
> 
> Previously it was assumed that idpf_vc_core_deinit() is always being called
> during reset handling, where the MBX is disabled by the reset, with remove
> being the exception. Ideally the driver needs to communicate the changes to
> FW in all instances where the MBX is not already disabled.
> Remove the remove_in_prog check from idpf_vc_core_deinit() as the MBX
> was already disabled while handling the reset via libie_ctlq_xn_shutdown() in
> the service task. This is also needed by the following patch, introducing PCI
> callbacks support, specifically in the case where FLR is being triggered by a
> user, in which case, the driver still has the ability to notify FW before the reset
> happens.
> 
> Add call to libie_ctlq_xn_shutdown() in idpf_shutdown() to avoid a possible
> regression where long timeouts can happen on shutdown when FW is down.
> 
> Signed-off-by: Emil Tantilov <[email protected]>
> Reviewed-by: Jay Bhat <[email protected]>
> Reviewed-by: Madhu Chittim <[email protected]>
> Reviewed-by: Aleksandr Loktionov <[email protected]>
> ---
> 2.37.3

Tested-by: Samuel Salin <[email protected]>