Re: [Intel-wired-lan] [PATCH] e1000: drop dead switch statements in configure_tx/rx
홍성준 <[email protected]> Wed, 29 Jul 2026 23:51:47 +0900
| Newsgroups | org.osuosl.intel-wired-lan,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
Thanks, then let us keep the switch statements. > On Jul 29, 2026, at 19:07, Jagielski, Jedrzej <[email protected]= > wrote: >=20 > =EF=BB=BFFrom: Seongjun Hong <[email protected]> > Sent: Wednesday, July 29, 2026 10:01 AM >=20 >> remove unnecessary branch >=20 > Hi Seongjun >=20 > First of all commit msg definitely needs to be extended. At least > start with capital letter, finish with dot etc >=20 > Once sending to netdev please also point target tree in commit title; > net-next for this case. >=20 > I see the point, but as the code is quite old and its extensive developmen= t > period passed long time ago, i believe value of such cosmetic patches is > rather questionable. >=20 >=20