Re: [Intel-wired-lan] [PATCH iwl-net v2 2/2] ice: fix stats array overflow via proper realloc

> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of S=
imon
> Horman
> Sent: Monday, July 13, 2026 4:04 PM
> To: Kitszel, Przemyslaw <[email protected]>
> Cc: Kwapulinski, Piotr <[email protected]>; Paolo Abeni
> <[email protected]>; [email protected]; Jagielski, Jedrzej
> <[email protected]>; Loktionov, Aleksandr
> <[email protected]>; Andrew Lunn <[email protected]>; Eri=
c
> Dumazet <[email protected]>; Marcin Szycik
> <[email protected]>; Nguyen, Anthony L
> <[email protected]>; Jakub Kicinski <[email protected]>; intel-wir=
ed-
> [email protected]; David S. Miller <[email protected]>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2 2/2] ice: fix stats arra=
y overflow
> via proper realloc
>=20
> On Tue, Jul 07, 2026 at 12:43:31AM +0200, Przemek Kitszel wrote:
> > Integrate ice_vsi_alloc_stat_arrays() with realloc variant.
> >
> > Instead of keeping two functions for stat arrays allocation, change
> > the
> > ice_vsi_realloc_stat_arrays() to handle initial condition (no vsi_stat
> > entry) and replace ice_vsi_alloc_stat_arrays() by the more generic
> > ice_vsi_realloc_stat_arrays().
> >
> > Note that VSIs of ICE_VSI_CHNL type are ignored in realloc variant as
> > they were in the replaced ice_vsi_alloc_stat_arrays().
> >
> > This is a fix for stats array overflow that occurs when VF is given
> > more queues (an operation that will be more frequent, and by bigger
> > increase, when we will merge my "XLVF" series).
> >
> > Splat for increasing number of queues thanks to Michal Schmidt:
> > KASAN detects the bug:
>=20
> ...
>=20
> > Fixes: 2a2cb4c6c181 ("ice: replace ice_vf_recreate_vsi() with
> > ice_vf_reconfig_vsi()")
> > Closes: https://redhat.atlassian.net/browse/RHEL-164321
> > Reviewed-by: Marcin Szycik <[email protected]>
> > Signed-off-by: Przemek Kitszel <[email protected]>
> > ---
> > This is an alternative to the fix [1] by Michal Schmidt, which were
> > blocked due to AI feedback. My fix was already developed before
> > Michal's, just not public back then. We have agreed to go on with my ve=
rsion.
> >
> > [1]
> > https://lore.kernel.org/netdev/20260520183501.3360810-3-anthony.l.nguy
> > [email protected]
>=20
> Reviewed-by: Simon Horman <[email protected]>
>=20
> ...

Tested-by: Rafal Romanowski <[email protected]>