Re: [Intel-wired-lan] [PATCH iwl-next v5 2/5] libeth: handle creating pools with unreadable buffers

Alexander Lobakin <[email protected]> Wed, 5 Aug 2026 16:21:56 +0200
Newsgroups org.osuosl.intel-wired-lan,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID <[email protected]>
From: Pavel Begunkov <[email protected]>
Date: Sun, 2 Aug 2026 14:02:11 +0100

> On 5/5/26 16:29, Alexander Lobakin wrote:
>> libeth uses netmems for quite some time already, so in order to
>> support unreadable frags / memory providers, it only needs to set
>> PP_FLAG_ALLOW_UNREADABLE_NETMEM when needed.
>> Also add a couple sanity checks to make sure the driver didn't mess
>> up the configuration options and, in case when an MP is installed,
>> return the truesize always equal to PAGE_SIZE, so that
>> libeth_rx_alloc() will never try to allocate frags. Memory providers
>> manage buffers on their own and expect 1:1 buffer / HW Rx descriptor
>> association.
> 
> Maybe I'm misreading it, but providers don't expect that. It's
> fine to use page_pool_alloc_frag_netmem() and friends, just like
> bnxt and other drivers do. net_iovs are refcounted in the same
> way as normal pages. Hope it helps.

Thanks, I'll double check. I could've misunderstood and done that due to
the unrelated problem which was fixed recently in the core.

Olek