Re: [Intel-wired-lan] [iwl-next] ixgbe: implement Total Port Shutdown for E610

On 8/10/26 09:56, Tomasz Lichwala wrote:
> Implement Total Port Shutdown (TPS) for E610. When TPS is provisioned
> in the NVM (by the platform firmware), the port's PHY is powered down
> whenever the interface is administratively down.
> 
> When the PORT_DIS bit is set in the Link Default Override TLV in
> the NVM PFA area, enable Total Port Shutdown (TPS). This forces the
> link-down-on-close private flag and prevents the user from changing
> it via ethtool, ensuring the PHY is powered down when the interface
> is brought down as provisioned in the NVM.
> 
> The Link Default Override TLV (0x134) is read from the NVM PFA during
> driver init. Each port has its own 10-word configuration block within
> the TLV. If the PORT_DIS bit is set in the port's link_options field,
> the driver sets both TOTAL_PORT_SHUTDOWN_ENA and LINK_DOWN_ON_CLOSE
> flags.
> 
> Signed-off-by: Tomasz Lichwala <[email protected]>
> ---
>   drivers/net/ethernet/intel/ixgbe/ixgbe.h      |  1 +
>   drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 38 +++++++++++++++++++
>   drivers/net/ethernet/intel/ixgbe/ixgbe_e610.h |  2 +
>   .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c  | 13 +++++++
>   drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 14 ++++++-
>   .../ethernet/intel/ixgbe/ixgbe_type_e610.h    | 13 +++++++
>   6 files changed, 80 insertions(+), 1 deletion(-)

Reviewed-by: Przemek Kitszel <[email protected]>

---
Sashiko failed to apply, likely because it assumes base as
"net-next/main" instead of "tony/dev-queue", and the former has no yet
a dependency from Jedrzej.

I'm sure you have checked it against our local Sashiko and it was fine,
although the model used was different.