Re: [Intel-wired-lan] [PATCH iwl-next v1 1/6] ixgbe: E610: init Link Status Events mask just once

> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of Jedrzej Jagielski
> Sent: 02 July 2026 14:46
> To: [email protected]
> Cc: Nguyen, Anthony L <[email protected]>; [email protected]; Jagielski, Jedrzej <[email protected]>; Loktionov, Aleksandr <[email protected]>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1 1/6] ixgbe: E610: init Link Status Events mask just once
>
> Current approach is that LSE mask is configured each time the LSE feature itself is toggled. The set of bits corresponding to LSE trigger causes remain the same for the whole ixgbe lifecycle. There's no support for enabling or disabling specific bits within LSE mask.
>
> This is redundant; there's no need to configure LSE mask over and over.
> The mask persists in hardware and only needs to be set once so should be separated from the LSE toggling logic.
>
> Do it just once at the init phase.
>
> Reviewed-by: Aleksandr Loktionov <[email protected]>
> Signed-off-by: Jedrzej Jagielski <[email protected]>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe.h      |  1 -
>  drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 34 ++++++++++++-------  drivers/net/ethernet/intel/ixgbe/ixgbe_e610.h |  3 +-  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 28 +++------------
> 4 files changed, 27 insertions(+), 39 deletions(-)
>

Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)