Re: [Intel-wired-lan] [PATCH iwl-next v1 6/6] ixgbe: take rtnl lock before ixgbe_reset() is called

> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of Jedrzej Jagielski
> Sent: 02 July 2026 14:46
> To: [email protected]
> Cc: Nguyen, Anthony L <[email protected]>; [email protected]; Jagielski, Jedrzej <[email protected]>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1 6/6] ixgbe: take rtnl lock before ixgbe_reset() is called
>
> Previous commit introduced ixgbe_mac_addr_refresh which touches netdev struct by updating mac addr. It should operate after taking rtnl lock.
> One of the callers is ixgbe_reset(). Most of scenarios when ixgbe_reset() is called met taking lock requirement, but there is a ixgbe_resume() path which calls ixgbe_reset() -> ixgbe_mac_addr_refresh() without taking the lock. So there is a risk of > race.
>
> Move rtnl_lock() before ixgbe_reset() is called.
>
> Signed-off-by: Jedrzej Jagielski <[email protected]>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)