Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: Fix incorrect LLDP filter assumptions

On Fri, Aug 14, 2026 at 09:07:09AM +0100, Simon Horman wrote:
> On Tue, Aug 11, 2026 at 02:11:27PM -0400, Dave Ertman wrote:
> > In commit 4d5a1c4e6d49 ("ice: do not add LLDP-specific filter if not
> > necessary"), it was assumed that llpd_fltr_ctrl was a unique application
> > of a filter instance and the other command in the flow was generic.
> > This is an incorrect assumption, they are both meant to add a filter to
> > handle LLDP packets and only varied in the actual AQ call made.  The
> > newer AQ call was created to handle a special case in some NVM images
> > where a LLDP filter was already existent and the old AQ command would
> > generate an error if a new filter was attempted to be added. The newer
> > AQ command would detect this case and instead would add the current
> > target to the existing filter rule.
> > 
> > Fix the flow so that the newer command is always used if available and
> > only fall back to the older command when that is the only solution.
> > 
> > Also remove the obsolete state flag from the PF struct.
> > 
> > Fixes: 4d5a1c4e6d49 ("ice: do not add LLDP-specific filter if not necessary")
> > Signed-off-by: Dave Ertman <[email protected]>
> > Reviewed-by: Przemek Kitszel <[email protected]>
> 
> Reviewed-by: Simon Horman <[email protected]>

Sorry for the duplicate, I forgot that I'd already sent this yesterday.